[FFmpeg-devel] [PATCH][VAAPI][6/6] Add H.264 bitstream decoding (take 6)

[Gwenole Beauchesne]

Le 16 avr. 09 ? 20:00, Michael Niedermayer a ?crit :

>> +    pic_param->bit_depth_luma_minus8                            =  
>> h->sps.bit_depth_luma   >= 8 ? h->sps.bit_depth_luma   - 8 : 0;
>> +    pic_param->bit_depth_chroma_minus8                          =  
>> h->sps.bit_depth_chroma >= 8 ? h->sps.bit_depth_chroma - 8 : 0;
>
> it cant be smaller 8 (not counting overflows on broken streams)

Mmmm, I think I had a case where it was needed, I will check again  
with my samples tomorrow.

>> +            p_luma_weight_flag   = &slice_param- 
>> >luma_weight_l1_flag;
>> +            p_luma_weight        = slice_param->luma_weight_l1;
>> +            p_luma_offset        = slice_param->luma_offset_l1;
>> +            p_chroma_weight_flag = &slice_param- 
>> >chroma_weight_l1_flag;
>> +            p_chroma_weight      = &slice_param->chroma_weight_l1;
>> +            p_chroma_offset      = &slice_param->chroma_offset_l1;
>> +        }
>
> could be simplified with a macro

Like in the new attachment?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg.hwaccel.vaapi.h264.6.patch
Type: application/octet-stream
Size: 16347 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090416/0f853829/attachment.obj>
-------------- next part --------------