[FFmpeg-devel] [PATCH] consistent display of metadata for ffmpeg/ffplay

[Peter Ross]

On Sat, Aug 08, 2009 at 09:02:11PM +0200, Michael Niedermayer wrote:
> On Sun, Aug 09, 2009 at 03:06:31AM +1000, Peter Ross wrote:
> > Hi, 
> > 
> > This patch moves the display of metadata to dump_format().
> > Some sample output:
> [...]
> >      /* open the streams */
> > diff --git a/libavformat/utils.c b/libavformat/utils.c
> > index 0c1a50d..80f4b1b 100644
> > --- a/libavformat/utils.c
> > +++ b/libavformat/utils.c
> > @@ -2916,6 +2916,14 @@ void dump_format(AVFormatContext *ic,
> >      } else
> >      for(i=0;i<ic->nb_streams;i++)
> >          dump_stream_format(ic, i, index, is_output);
> > +    if (ic->metadata) {
> > +        AVMetadataTag *tag=NULL;
> > +        printf("  Metadata\n");
> > +        while((tag=av_metadata_get(ic->metadata, "", tag, AV_METADATA_IGNORE_SUFFIX))) {
> > +            printf("    %s: %s\n", tag->key, tag->value);
> 
> i think these should be av_log

Yep. Otherwise, are there any comments on the presentation?

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dispmetadata-r2.diff
Type: text/x-diff
Size: 1431 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090809/2b6aeed0/attachment.diff>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090809/2b6aeed0/attachment.pgp>