[FFmpeg-devel] [PATCH 4/6] asfdec: convert variable-length array to fixed size

[Michael Niedermayer]

On Sat, Aug 22, 2009 at 04:03:25PM +0100, M?ns Rullg?rd wrote:
> Michael Niedermayer <michaelni at gmx.at> writes:
> 
> > ssOn Wed, Aug 19, 2009 at 02:23:00AM +0100, Mans Rullgard wrote:
> >> MAX_STREAMS is small enough that it doesn't matter
> >> ---
> >>  libavformat/asfdec.c |    2 +-
> >>  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > we wanted to get rid of MAX_STREAMS limits thus this one would be just
> > moving more work on the poor guy who actually tries to get rid of it
> 
> Good point, but then we should still do something else with this,
> since if that limit goes away, this would be requesting an unbounded
> amount of stack space, which is not a good idea.  Is malloc/free
> acceptable in this function?

yes i think so, it seems not called often enough

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are too smart to engage in politics are punished by being
governed by those who are dumber. -- Plato 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090823/f7448a9e/attachment.pgp>