[FFmpeg-devel] [PATCH] DeluxePaint Animation playback system

[Peter Ross]

On Wed, Aug 26, 2009 at 02:15:06PM +0200, Reimar D?ffinger wrote:
> On Wed, Aug 26, 2009 at 08:45:33PM +1000, Peter Ross wrote:

> > +#define LPF_TAG  MKTAG('L','P','F',' ')
> > +#define ANIM_TAG MKTAG('A','N','I','M')
> > +
> > +static int probe(AVProbeData *p)
> > +{
> > +    /* verify tags and video dimensions */
> > +    if (AV_RL32(&p->buf[0]) == LPF_TAG &&
> > +        AV_RL32(&p->buf[16]) == ANIM_TAG &&
> 
> AV_RN32(p->buf     ) == AV_RN32("LPF ") &&
> AV_RN32(p->buf + 16) == AV_RN32("ANIM") &&
> 
> Seems nicer to me.

Also seems bloatier! Unless the compiler has telepathic qualities, it's
going to shove the "LPF " string in the data segment. Besides, this only
looks nice when working with little endian tags...
 
> That will probably mean your code can't work with AVFMT_GENERIC_INDEX.
> I really think that seeking should be working.

There is only one guaranteed keyframe: the first frame!

I'll tackle fixing the rest over the weekend. Cheers,

-- Peter
(A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090829/0d71ac34/attachment.pgp>