[FFmpeg-devel] [PATCH] Fix memory leak in theora encoder

[Ramiro Polla]

On Sun, Jul 12, 2009 at 4:59 PM, Art Clarke<aclarke at xuggle.com> wrote:
> On Tue, Jul 7, 2009 at 12:57 PM, Art Clarke <aclarke at xuggle.com> wrote:
>> Ping again. ?Reattaching patch to save you going back.
> Ping again. ?Can someone review and either comment, reject, or apply?

> Index: libavcodec/libtheoraenc.c
> ===================================================================
> --- libavcodec/libtheoraenc.c	(revision 19361)
> +++ libavcodec/libtheoraenc.c	(working copy)
> @@ -150,6 +150,11 @@
>      if (concatenate_packet( &offset, avc_context, &o_packet ) != 0) {
>          return -1;
>      }
> +    /* Clear up theora_comment struct before we reset the packet */
> +    theora_comment_clear( &t_comment );
> +    /* And despite documentation to the contrary, theora_comment_clear
> +     * does not release the packet */
> +    ogg_packet_clear(&o_packet);

Isn't this a bug in libtheora or their documentation? Has it been reported?