[FFmpeg-devel] [PATCH] Remove unused variable from videogen.c

[Michael Niedermayer]

On Mon, Jul 20, 2009 at 10:46:07PM +0000, Carl Eugen Hoyos wrote:
> Michael Niedermayer <michaelni <at> gmx.at> writes:
> 
> > On Mon, Jul 20, 2009 at 11:44:28PM +0200, Carl Eugen Hoyos wrote:
> > > icc reports:
> > > tests/videogen.c(203): remark #593: variable "dy" was set but never used
> > >       int r, g, b, x, y, i, dx, dy, x1, y1;
> > >                                 ^
> 
> [...]
> 
> > id rather suspect the following
> > 
> >             x1 = (x << FRAC_BITS) + dx;
> >             y1 = (y << FRAC_BITS) + dx;
> >                                     ^^
> >                             should probably be dy
> 
> As you probably expected, this changes all regression tests.
> 
> Do you want me to commit the change including the regression test changes?

probably yes

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

When you are offended at any man's fault, turn to yourself and study your
own failings. Then you will forget your anger. -- Epictetus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090721/1456420d/attachment.pgp>