[FFmpeg-devel] [PATCH] encoder for adobe's flash ScreenVideo2 codec

[Diego Biurrun]

On Tue, Jul 21, 2009 at 01:09:04PM -0600, Joshua Warner wrote:
> On Tue, Jul 21, 2009 at 11:46 AM, Diego Biurrun <diego at biurrun.de> wrote:
> >
> > On Tue, Jul 21, 2009 at 08:57:15AM -0600, Joshua Warner wrote:
> > >
> > > I've developed an encoder for Adobe's Flash ScreenVideo2 format, which is
> > > stored in flv files. ?My encoder currently only supports a large subset of
> > > the format. ?The only player that supports this codec (so far) is Adobe
> > > Flash Player itself,
> >
> > What about writing a decoder first?
> 
> I didn't write the decoder first because I never found full example
> files to test it on (only fragments garnered by monitoring network
> traffic during an Adobe Breeze recording).? I can test the encoder by
> playing the resulting files in flash player.  Plus, as of now, I have
> no need for a decoder.  I will get to it, eventually...

Maybe Mike can provide you some samples..

> > Your patch is missing a documentation update.
> 
> What, exactly needs to be changed here?

Add a line to doc/general.texi that flash sv2 is supported.

> > > +#define FLASHSV2_DUMB
> 
> FLASHSV2_DUMB forces the encoder to use the build-in defaults instead
> of the experimental "smart" parameter-choosing code, which (as
> described in my original post) I haven't been able to get it to make
> decisions that are consistently better than the defaults.? I wanted to
> leave the "smart" code in place as a starting point for future work on
> this tangent.? Should I do this differently?

Please add a comment in the code that explains it.

Diego