[FFmpeg-devel] [PATCH] Bluray Subtitle Support, v4

[compn]

On Tue, 28 Jul 2009 19:29:50 +1000, stev391 at exemail.com.au wrote:
>On Sat, 2009-07-25 at 10:13 +1000, stev391 at exemail.com.au wrote:
>> On Fri, 2009-07-24 at 15:23 +0200, Diego Biurrun wrote:
>> > On Fri, Jul 24, 2009 at 05:57:24PM +1000, stev391 at exemail.com.au wrote:
>> > > 
>> > > Updated patch including Diego's, Aurelien's & Baptiste's comments.
>> > > Thanks for the excellent and quick feedback.
>> > 
>> Thanks again for the comments, I'm glad somebody is interested in my
>> patch.
>> 
>> Updated patch (from v2) to include Diego's & Aurelien's comments.
>
>Updated patch to version 4.
>
>The previous patch kept allocating memory each time a subtitle was
>decoded and never freeing the bitmap memory.  This originally was
>completed after the subtitle was displayed, however as the start time is
>so delayed it meant the subtitle were cleared to early.  Now I free the
>memory if it is allocated before allocating the new bitmap size.

did you run your code in valgrind to find more leaks?
(not saying this has to be done to get approved, but ...)

-compn