[FFmpeg-devel] [PATCH] Check for signal.h, conditionally compile parts of ffmpeg.c

Ramiro Polla ramiro.polla
Tue Jul 28 22:55:53 CEST 2009


On Fri, Jul 17, 2009 at 4:48 AM, Martin Storsj?<martin at martin.st> wrote:
> On Wed, 15 Jul 2009, Martin Storsj? wrote:
>> On Tue, 14 Jul 2009, M?ns Rullg?rd wrote:
>> > There is no need for this to variable to be sig_atomic_t in the first
>> > place. ?The worst that could possibly happen is the encoding loop
>> > doing one extra iteration, and that only if an 'int' cannot be read in
>> > a single instruction, which is exceedingly unlikely to be the case on
>> > any platform we'll ever support.
>>
>> Ok, updated the patch series to start by changing this to an int.
>
> Here's another update to the patch series; I noticed that not all
> HAVE_SIGNAL_H checks in ffmpeg.c were needed.

Is it necessary to check for HAVE_SIGNAL_H in the #ifdef HAVE_TERMIOS_H part?



More information about the ffmpeg-devel mailing list