[FFmpeg-devel] [RFC] TwinVQ decoder

[Baptiste Coudurier]

Hi,

On 3/7/2009 10:45 AM, Diego Biurrun wrote:
> On Sat, Mar 07, 2009 at 05:47:51PM +0100, Vitor Sessak wrote:
>> This code is still not review-quality, but any comment is welcome.
>>
>> /**
>>  * Parameters and tables that are different for each frame type
>>  */
>> typedef struct {
>>     uint8_t   sub;
>>     const uint16_t *crb_tbl;
>>     uint8_t   n_crb;
>>     const float *fw_cb;
>>     uint8_t   fw_n_div;
>>     uint8_t   fw_n_bit;
>>     const float *cb0;
>>     const float *cb1;
>>     uint8_t   cb_len_read;
>> } FrameMode;
> 
> This would be more readable aligned.
> 
>> typedef struct {
>>     const FrameMode fmode[3];
>>
>>     uint16_t  n_fr;
>>     uint8_t   n_pr;
>>     const float *lspcodebook;
>>     uint8_t   lsp_bit0;
>>     uint8_t   lsp_bit1;
>>     uint8_t   lsp_bit2;
>>     uint8_t   lsp_split;
>>     const float *pit_cb;
>>     uint8_t   basf_bit;
>>     uint8_t   pit_n_bit;
>>     uint8_t   pit_cb_len;
>>     uint8_t   pgain_bit;
>> } ModeTab;
> 
> I don't like typedefs :)

I do like typedefs :)

[...]

-- 
Baptiste COUDURIER                              GnuPG Key Id: 0x5C1ABAAA
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
checking for life_signs in -lkenny... no
FFmpeg maintainer                                  http://www.ffmpeg.org