[FFmpeg-devel] [PATCH] libavdevice: JACK demuxer

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Sat, Mar 07, 2009 at 11:04:25PM +0100, Reimar D?ffinger wrote:
>> On Sat, Mar 07, 2009 at 10:03:13PM +0100, Michael Niedermayer wrote:
>> > On Sat, Mar 07, 2009 at 06:05:06PM +0100, Michael Niedermayer wrote:
>> 
>> > > > I was once thinking about just using fifo.c, but since it uses bytes
>> > > > as basic unit (instead of a e.g. 1kB block), it allocates exactly one
>> > > > additional byte, causing alignment issues after the first loop through
>> > > > the buffer.
>> > > 
>> > > id love to see libavutil/fifo extended to fix the 1 byte issue and 
>> > > whatever else is needed.
>> > 
>> > the 1 byte issue should be fixed
>> > can you confirm that this is enough for mplayer or is more needed?
>> 
>> It is all I can currently think of (even though not using volatile feels
>> wrong to me even though it is completely pointless to use it :-) ).
>
> Feel free to add volatile though as you say its pointless ...

Using volatile is almost always wrong.  See
Documentation/volatile-considered-harmful.txt in the Linux kernel
source for a good discussion on the topic.

-- 
M?ns Rullg?rd
mans at mansr.com