[FFmpeg-devel] [PATCH][VAAPI][2/6] Add common data structures and helpers (take 12)

[Gwenole Beauchesne]

On Thu, 12 Mar 2009, Michael Niedermayer wrote:

> [...]
>> +    av_freep(&p->bitplane_buffer);
>> +    av_freep(&p->slice_buf_ids);
>> +    p->n_slice_buf_ids     = 0;
>> +    p->slice_buf_ids_alloc = 0;
>> +    av_freep(&p->slice_params);
>> +    p->slice_count         = 0;
>> +    p->slice_params_alloc  = 0;
>
> you can group the av_freep() together

Resend. Did all changes even this one though I prefer grouping code by 
semantics rather than by cosmetics... slice_params kept as is though. 
Reminder: pointer arith on void * is not possible and 
sizeof(VASliceParameterBufferBase) != sizeof(VASliceParameterBufferCODEC).

BTW, also fixed commit_slices() to commit slices only if there are 
actually ones pending.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ffmpeg.hwaccel.vaapi.common.12.patch
Type: text/x-diff
Size: 13597 bytes
Desc: 
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090318/f2f95f3c/attachment.patch>