[FFmpeg-devel] [PATCH] swscale alpha channel support

[Michael Niedermayer]

On Tue, Mar 24, 2009 at 10:24:40AM +0100, C?dric Schieli wrote:
> 2009/3/24 C?dric Schieli <cschieli at gmail.com>:
> > 2009/3/24 Michael Niedermayer <michaelni at gmx.at>:
> >> On Mon, Mar 23, 2009 at 03:53:28PM +0100, C?dric Schieli wrote:
> >>> Hi all,
> 
> [...]
> 
> >>> #4 : palette8topacked32.patch
> >>> use default value of 255 for the alpha channel in unscaled paletted to
> >>> rgb32 converters
> >>
> >> a very quick looks gives me the feeling this is wrong?
> >> isnt the alpha supposed to be in the palette already?
> >
> > true for PAL8, but not for BGR8/RGB8/BGR4_BYTE/RGB4_BYTE
> > so a separate code path seems needed for PAL8 (what is the index for
> > the alpha color in PAL8 ?)
> 
> Ok, it's better to read the code before replying.
> Attached is a new patch that use the alpha stored in the PAL8 palette,
> and default to 255 for the BGR8/RGB8/BGR4_BYTE/RGB4_BYTE case.

i still think this is wrong
BGR8/RGB8/BGR4_BYTE/RGB4_BYTE should have a valid palette set and that
should include the alpha byte

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No great genius has ever existed without some touch of madness. -- Aristotle
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090324/4300ecfd/attachment.pgp>