[FFmpeg-devel] [Fwd: Summer of code small task patch]

[Michael Niedermayer]

On Sat, Mar 28, 2009 at 12:42:46PM +0100, Diego Biurrun wrote:
> On Sat, Mar 28, 2009 at 06:23:14AM +0100, Michael Niedermayer wrote:
> > On Fri, Mar 27, 2009 at 10:18:07PM +0200, Dylan Yudaken wrote:
> > >
> > > --- libavcodec/dct-test.c	(revision 18203)
> > > +++ libavcodec/dct-test.c	(working copy)
> > > @@ -46,9 +46,9 @@
> > >  void *fast_memcpy(void *a, const void *b, size_t c){return memcpy(a,b,c);};
> > >  
> > >  /* reference fdct/idct */
> > > -void fdct(DCTELEM *block);
> > > -void idct(DCTELEM *block);
> > > -void init_fdct(void);
> > > +void ff_ref_fdct(DCTELEM *block);
> > > +void ff_ref_idct(DCTELEM *block);
> > > +void ff_ref_dct_init(void);
> > 
> > renaming things should be a seperate patch
> > actually a patch should either do functional changes or non functional not
> > both
> 
> I think this should be treated differently, he is creating an entirely
> new and independent file.  Adding a renaming step in between is
> pointless extra work.

What do you suggest exactly?

Its surely possible to replace the code and then rename the functions.
Its also surely possible to rename first and then replace.

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Avoid a single point of failure, be that a person or equipment.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090328/c97f6918/attachment.pgp>