[FFmpeg-devel] [RFC] Scalar color conversion utils (colorutils.[hc])?

[Michael Niedermayer]

On Mon, May 04, 2009 at 01:08:33AM +0200, Stefano Sabatini wrote:
> On date Monday 2009-05-04 00:25:59 +0200, Michael Niedermayer encoded:
> > On Sun, May 03, 2009 at 03:42:04PM +0200, Stefano Sabatini wrote:
> > > On date Saturday 2009-05-02 22:11:42 +0200, Michael Niedermayer encoded:
> > > > On Sat, May 02, 2009 at 09:37:09PM +0200, Stefano Sabatini wrote:
> > > > > On date Saturday 2009-05-02 18:45:49 +0200, Michael Niedermayer encoded:
> > > [...]
> > > > > > Once lavfi is merged this could be revissited but we surely wont combine
> > > > > > the string parsing with colorspace convertion because frankly that is
> > > > > > unflexible.
> > > > > 
> > > > > Would be:
> > > > > int av_parse_color(uint16_t *rgba_color, const char *color_string, void *log_ctx);
> > > > > 
> > > > > an acceptable solution?
> > > > 
> > > > this looks better
> > > 
> > > Patch updated (as usage example I'm going to post an updated version
> > > of the RGBA source).
> > > 
> > > Regards.
> > > -- 
> > > FFmpeg = Fierce and Faithless Marvellous Portable Ecstatic Gadget
> > 
> > >  Makefile     |    3 
> > >  colorutils.c |  249 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> > >  colorutils.h |   41 +++++++++
> > >  3 files changed, 293 insertions(+)
> > > 9b57e8b85216d7af4169a2aec2df2aca4a10b1e3  implement-colorutils.patch
> > > Index: libavfilter-soc/ffmpeg/libavfilter/colorutils.c
> > > ===================================================================
> > > --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> > > +++ libavfilter-soc/ffmpeg/libavfilter/colorutils.c	2009-05-03 14:38:23.000000000 +0200
> > 
> > wouldnt that stuff fit in parseutils.* ?
> 
> Yes that's a possibility, as you prefer.

i do prefer it

[...]

>  colorutils.c |  246 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  colorutils.h |   41 +++++++++
[...]
> +/**
> + * Parses the color string in color_string, and puts in rgba_color the
> + * RGBA component values of the corresponding color.

Returns the rgba values that correspond to the given string.

or something else english ;)


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is not what we do, but why we do it that matters.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20090504/ff9c2730/attachment.pgp>