[FFmpeg-devel] [PATCH] Add DPX decoder

[Benjamin Larsson]

Jimmy Christensen wrote:
>
> +    char endian = 0x0;
>   

I'd prefer an int for this flag.

> +
> +    magic_num = AV_RB32(headerBuffer);
> +    headerBuffer += 4;
> +    // Check if the files "magic number" is "SDPX" which means it uses big endian or XPDS which is for little endian files
> +    if (magic_num == 0x53445058)
>   

MKTAG('S', 'D', 'P', 'X') instead of 0x53445058.


I would do like this to do some error handling also:

if (SDPX)
  endian=1
else if (XPDS)
  endian=2
else
  av_log("DPX marker not found")
  return -1


MvH
Benjamin Larsson