[FFmpeg-devel] [PATCH] Yet another stab at RGB48 support

[Kostya]

On Sat, May 23, 2009 at 07:19:28PM +0200, Michael Niedermayer wrote:
> On Sat, May 23, 2009 at 03:43:33PM +0300, Kostya wrote:
> > On Sat, May 23, 2009 at 02:25:23PM +0200, Michael Niedermayer wrote:
> > > On Sat, May 23, 2009 at 03:18:35PM +0300, Kostya wrote:
> > > > On Sat, May 23, 2009 at 02:01:14PM +0200, Michael Niedermayer wrote:
> > > > > On Sat, May 23, 2009 at 07:25:04AM +0300, Kostya wrote:
> > > > > > On Sat, May 23, 2009 at 03:47:46AM +0200, Michael Niedermayer wrote:
> > > > > > > On Fri, May 22, 2009 at 08:31:41AM +0300, Kostya wrote:
> > > > [...]
> > > > > > 
> > > > > > for almost all non-YUV converters (with the only exception being
> > > > > > rgb24To{Y,UV} and bgr24To{Y,UV}) there's only C code
> > > > > > 
> > > > > > So it's up to you to decide how to deal with this.
> > > > > 
> > > > > I already said it, if there is just the C code, then the function doesnt
> > > > > belong in the template.
> > > > > Ive missed this issue until now so a few functions accumulated that should
> > > > > not be there ...
> > > > 
> > > > Since it's only you who can say where and how it should be moved to, I wait
> > > 
> > > swscale.c
> > 
> > While it would make swscale.c and swscale_template.c sizes more equal,
> > those functions are referenced from template sws_init_swScale()
> 
> yes and?
 
so pointers to hyscale and hcscale should be initialized somewhere else
in a way like RENAME(sws_init_swScale) does.
 
> > - so
> > is partial code duplication a good thing here (for initializing
> > pointers)?
> 
> code duplication means patch rejected

Could you please do that (move the functions around)? You know swscaler code
the best while it will take anybody else a lot of tries to get it right.

> [...]
> 
> -- 
> Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB