[FFmpeg-devel] flac/alac bug: alac encoder uses flac_compute_autocorr, but that is not availabe without flac

[Michael Niedermayer]

On Fri, Oct 16, 2009 at 05:36:17PM -0400, Justin Ruggles wrote:
> Justin Ruggles wrote:
> 
> > Reimar D?ffinger wrote:
> > 
> >> Hello,
> >> maybe I'm wrong, but could the maintainers please have a look at it?
> >> It seems to me that the alac encoder uses ff_lpc_calc_coefs, which in
> >> turn requires flac_compute_autocorr, but that one is NULL if the
> >> FLAC encoder is disabled - thus a build with flac disabled will crash
> >> when encoding alac.
> >> This is also issue 1486
> > 
> > Perhaps we should move the C version to either lpc.c or dsputil.c.
> 
> Patch attached.  I do maintain LPC and FLAC, but this also messes around
> with dsputil stuff so I thought I should post a patch before committing.
> 
> -Justin
> 

>  Makefile             |    2 
>  dsputil.c            |    8 +-
>  dsputil.h            |    2 
>  flacenc.c            |   63 -----------------------
>  lpc.c                |   64 +++++++++++++++++++++++
>  x86/dsputilenc_mmx.c |    6 --
>  x86/flacdsp_mmx.c    |  139 ---------------------------------------------------
>  x86/lpc_mmx.c        |    4 -
>  8 files changed, 72 insertions(+), 216 deletions(-)
> 01d7a90780bd6b4eceb353116680c5c0cecc4485  move_autocorrelation.diff

ok

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If a bugfix only changes things apparently unrelated to the bug with no
further explanation, that is a good sign that the bugfix is wrong.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091017/646f9e74/attachment.pgp>