[FFmpeg-devel] [PATCH] fix sdp(file) vs rtsp dep

[Luca Abeni]

On Sun, 2009-10-18 at 20:50 +0200, Diego Biurrun wrote:
[...]
> > >  rtp_muxer_deps="network rtp_protocol"
> > > -rtsp_demuxer_deps="sdp_demuxer"
> > > -sdp_demuxer_deps="rtp_protocol mpegts_demuxer"
> > > +rtsp_demuxer_deps="rtp_protocol mpegts_demuxer"
> > > +sdp_demuxer_deps="rtsp_demuxer"
> > 
> > I think these dependencies are correct as they are now: the RTSP demuxer
> > depends on the SDP demuxer, and not vice-versa (or, if you prefer, the
> > RTSP demuxer is a superset of the SDP demuxer). From the practical point
> > of view, I do not think this makes any difference, but from the
> > theoretical point of view I think it's better to indicate the correct
> > dependency here.
> 
> Then the functions which are really SDP functions should be renamed.
> 
> Right now the code and the dependency declaration in the build system
> are contradictory.  That's why it fails to build in some configurations.

I do not disagree with this. I was just trying to point out that this
part of the patch is unneeded and (IMHO) wrong.

> Decide which of the two possibilities is the better one and fix the
> issue in one direction or the other.

I had no time to test it, but I suspect Luca's patch without the
previous hunk works just fine. I'll do some tests tomorrow.


			Luca