[FFmpeg-devel] [PATCH] fix sdp(file) vs rtsp dep

[Diego Biurrun]

On Sun, Oct 18, 2009 at 11:01:13PM +0200, Luca Abeni wrote:
> On Sun, 2009-10-18 at 20:55 +0200, Diego Biurrun wrote:
> > On Sun, Oct 18, 2009 at 08:34:27PM +0200, Luca Abeni wrote:
> > > On Sun, 2009-10-18 at 12:59 +0200, Diego Biurrun wrote:
> > > [...]
> > > > All of the RTP/SDP/RTSP code seems to be in for a great refactoring.
> > > > For example:
> > > > 
> > > > - sdp.o is not compiled conditionally and is enclosed in
> > > >   '#if CONFIG_RTP_MUXER'.  This should be done in the Makefile instead
> > > >   and the file should be called rtp.o if that's what it implements.
> > > This is a different thing, I think: sdp.c exports a public function
> > > called avf_sdp_create(). If the RTP muxer is not compiled in, such
> > > function fails.
> > 
> > I have seen this.  What is the function good for?
> 
> It generates an SDP description of an RTP session.

Let me refine my question: Why does it have to be part of the public
API?

> > If the RTP muxer depends on this, declare that dependency in
> > configure.
> 
> There is no such dependency: the RTP muxer can work even without an SDP
> generator (assuming the SDP has been previously generated, or is
> generated in some other way).

Then the preprocessor condition used in sdp.c is wrong.
CONFIG_RTP_MUXER means that it depends on the RTP muxer.

Diego