[FFmpeg-devel] [PATCH] Add scale filter

[Diego Biurrun]

On Sun, Oct 11, 2009 at 11:29:35PM +0200, Stefano Sabatini wrote:
> 
> --- ffmpeg.orig/doc/vfilters.texi	2009-10-11 23:18:46.000000000 +0200
> +++ ffmpeg/doc/vfilters.texi	2009-10-11 23:18:48.000000000 +0200
> @@ -120,4 +120,20 @@
>  
> + at section scale
> +
> +Scale to new width/height to w:h and/or convert pixel format.

This is seriously confusing.  You are basically saying

  Go to France to Australia and do something else.

So what was it you are trying to say?

Please make an effort to express yourself clearly.

> +If ``w'' or ``h'' is 0, the corresponding input size is used. If ``w''
> +or ``h'' is -1, the scale filter will use a value keeping the same
> +aspect ratio as the image in input.

use a value that maintains the aspect ratio of the input image

> Index: ffmpeg/libavfilter/Makefile
> --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> +++ ffmpeg/libavfilter/vf_scale.c	2009-10-11 23:20:36.000000000 +0200
> @@ -0,0 +1,189 @@
> +
> +static AVFilterPicRef *get_video_buffer(AVFilterLink *link, int perms, int w, int h)

Please break pointlessly long lines.

Diego