[FFmpeg-devel] [PATCH] Add writing of vorbis comments to flac files

[Diego Biurrun]

On Thu, Oct 22, 2009 at 03:47:21AM +0200, James Darnley wrote:
> 
> --- libavformat/flacenc.c	(revision 20344)
> +++ libavformat/flacenc.c	(working copy)
> @@ -45,9 +50,62 @@
>  
> +    while(n_padding_bytes > 0) {

while (

> +    /* the command line flac encoder defaults to placing a seekpoint
> +     * every 10s, so one might add padding to allow that later
> +     * but there seems to be no simple way to get the duration here
> +     * so lets try the flac default of 8192 bytes */

s/lets/let us/

Also, make this three sentences, use proper capitalization and end
sentences in periods.

> --- libavformat/vorbiscomment.h	(revision 0)
> +++ libavformat/vorbiscomment.h	(revision 0)
> @@ -0,0 +1,36 @@
> +
> +/* p requires the number of bytes returned by ff_vorbis_comment_length() */
> +int ff_vorbis_comment_write(uint8_t **p, AVMetadata *m, const char *vendor_string);

needlessly long line

Diego