[FFmpeg-devel] PATCH rtsp/sdp/multicast

[armand bendanan]

> -----Original Message-----
> From: ffmpeg-devel-bounces at mplayerhq.hu [mailto:ffmpeg-devel-
> bounces at mplayerhq.hu] On Behalf Of Diego Biurrun
> Sent: vendredi 23 octobre 2009 13:16
> To: FFmpeg development discussions and patches
> Subject: Re: [FFmpeg-devel] PATCH rtsp/sdp/multicast
> 
> On Fri, Oct 23, 2009 at 03:48:37AM +0200, armand bendanan wrote:
> >
> > > On Wed, Oct 21, 2009 at 10:03:03PM +0200, armand bendanan wrote:
> > > >
> > > > --- old/libavformat/rtsp.c	2009-10-21 19:47:39.000000000 +0200
> > > > +++ ffmpeg/libavformat/rtsp.c	2009-10-21 20:06:59.000000000 +0200
> > > > @@ -1125,12 +1125,24 @@
> > > >                  char url[1024];
> > > >                  struct in_addr in;
> > > > +                int port;
> > > > +                int ttl;
> > >
> > > Merge this into one line.
> > >
> > > > +            		port = reply->transports[0].port_min;
> > > > +            		ttl = reply->transports[0].ttl;
> > >
> > > The '=' could be aligned.
> > >
> > > > +            		in = rtsp_st->sdp_ip;
> > > > +            		port = rtsp_st->sdp_port;
> > > > +            		ttl = rtsp_st->sdp_ttl;
> > >
> > > same here
> > >
> > > >                  snprintf(url, sizeof(url), "rtp://%s:%d?ttl=%d",
> > > >                           inet_ntoa(in),
> > > > -                         reply->transports[0].port_min,
> > > > -                         reply->transports[0].ttl);
> > > > +                         port,
> > > > +                         ttl);
> > >
> > > shorter:
> > >
> > >   snprintf(url, sizeof(url), "rtp://%s:%d?ttl=%d",
> > >            inet_ntoa(in), port, ttl);
> > >
> > > Also, get rid of all the tabs.
> >
> > Here is the new corrected patch.
> 
> I would hardly call it that.  You addressed at most half of the issues I
> pointed out.
> 

OK, diego, I got also a reply from Stefano.
Here a new patch.

 

__________ Information from ESET NOD32 Antivirus, version of virus signature
database 4536 (20091023) __________

The message was checked by ESET NOD32 Antivirus.

http://www.eset.com
 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patchabe_2.diff
Type: application/octet-stream
Size: 1709 bytes
Desc: not available
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20091023/089038a3/attachment.obj>