[FFmpeg-devel] [PATCH] Add writing of vorbis comments to flac files

[Justin Ruggles]

James Darnley wrote:

> 2009/10/23 Justin Ruggles <justin.ruggles at gmail.com>:
>> no mixed case function names. either vorbis_comment or vorbiscomment are
>> equally ok i think.
>>
> I changed them to "vorbiscomment" because that is consistent with
> ff_vorbiscomment_metadata_conv which existed before
> 
>>> +int ff_vorbis_comment_write(uint8_t **p, AVMetadata *m,
>>> +                            const char *vendor_string)
>>> +{
>>> +    int i;
>>> +    bytestream_put_le32(p, strlen(vendor_string));
>>> +    av_log(NULL, AV_LOG_ERROR, "[VorbisComment] %d %s\n", strlen(vendor_string), vendor_string);
>> looks like this line slipped in by accident...
>>
> Oooh, sorry about that.
> 
>>> +/**
>>> + * Writes a VorbisComment into a buffer. The buffer, p, must have enough
>>> + * data to hold the whole VorbisComment. The minimum size required can be
>>> + * obtained by passing the same AVMetadata and vendor_string to
>>> + * ff_vorbis_comment_length()
>>> + *
>>> + * @param p The buffer in which to write.
>>> + * @param m The metadata struct you want to write.
>>> + * @param vendor_string The vendor string you want to write.
>>> + */
>>
>> This function documentation needs some similar editing to what you did
>> to the other.
>>
> Is that better now?

The patch looks good to me.  Aurel, any comments/suggestions?  or anyone
else.

-Justin