[FFmpeg-devel] [PATCH] remove pnm code cruft

[Daniel Verkamp]

On Tue, Oct 27, 2009 at 11:29 AM, Diego Biurrun <diego at biurrun.de> wrote:
> On Tue, Oct 27, 2009 at 02:49:02PM +0100, Michael Niedermayer wrote:
>> On Tue, Oct 27, 2009 at 01:58:53PM +0100, Diego Biurrun wrote:
>> > On Tue, Oct 27, 2009 at 01:49:42PM +0100, Michael Niedermayer wrote:
>> > > On Tue, Oct 27, 2009 at 10:44:12AM +0000, M?ns Rullg?rd wrote:
>> > > > Michael Niedermayer <michaelni at gmx.at> writes:
>> > > >
>> > > > > On Tue, Oct 27, 2009 at 11:06:03AM +0100, Diego Biurrun wrote:
>> > > > >> This removes some cruft from pnmenc.c. ?I intend to split the file
>> > > > >> afterwards, so removing cruft seems like a good first step.
>> > > > >
>> > > > > instead of removing the probe code, the code should be used
>> > > >
>> > > > That code is a remnant from when this file was in lavf.
>> > >
>> > > yes
>> > >
>> > > > ?It should be deleted.
>> > >
>> > > no
>> > > Id like to have functioning image2 probing.
>> >
>> > > This code should be exported from the decoder (AVCodec.probe maybe)
>> > > and then img2.c image_probe() should call that for all image codecs
>> > > for probing instead of pure filename extension based probing.
>> >
[...]

Assuming one wanted to implement image2 probing, how would the probe
parameters be passed - should struct AVProbeData and related #defines
be moved from avformat.h to some common location or duplicated
somewhere else?  I assume it is not acceptable to just #include
avformat.h in libavcodec code, but lavf code does seem to #include
avcodec.h, so perhaps moving AVProbeData to some header in libavcodec/
would be correct?

Thanks,
-- Daniel Verkamp