[FFmpeg-devel] [PATCH] Fix ffserver.c warnings
Måns Rullgård
mans
Tue Mar 9 01:50:27 CET 2010
Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
> On date Monday 2010-03-08 22:05:42 +0000, M?ns Rullg?rd encoded:
>> Stefano Sabatini <stefano.sabatini-lala at poste.it> writes:
>>
>> > Hi, check attached patch.
>> >
>> > I'm not sure which functions should actually be declared outside the
>> > #ifdef HAVE_AV_CONFIG_H ..
> [...]
>> I saw someone saying just a day ago that ff_url_split() was not a
>> public function, and the naming indicates this was the intent too.
>> I don't know what the networking people want ffserver to use here.
>>
>> Since the unused and deprecated match_ext() is under ifdef
>> HAVE_AV_CONFIG_H, it is safe to delete it immediately.
>
> Done.
>
> Maybe it would be a good idea to move all the ifdeffed/internal
> functions under libavformat/internal.h.
Agree.
--
M?ns Rullg?rd
mans at mansr.com
More information about the ffmpeg-devel
mailing list