[FFmpeg-devel] ICC version checks

[Måns Rullgård]

Carl Eugen Hoyos <cehoyos at ag.or.at> writes:

> M?ns,
>
> M?ns Rullg?rd <mans <at> mansr.com> writes:
>
>> How ridiculous of them.  With that being that case, what purpose does
>> the icc version check serve, given that the accompanying gcc version
>> check is totally bogus in this case?
>> 
>> These tests are ugly and confusing.  I'd like to replace them by
>> something clean and, if possible, correct.  Any suggestions?
>
> sorry, but I do not understand you:
> The version checks make sure that on all supported icc versions,
> only supported attributes are used (as for gcc).
> They are correct (as far as I tested), and I can't think of an
> alternative that would be as simple.

You said yourself that icc does _not_ support everything the random
gcc version it claims to be does.  Ergo, the tests are wrong for icc.

-- 
M?ns Rullg?rd
mans at mansr.com