[FFmpeg-devel] [RFC] move some *_tablegen.c defines to Makefile

[Reimar Döffinger]

On Mon, Mar 22, 2010 at 12:27:19AM +0000, M?ns Rullg?rd wrote:
> Reimar D?ffinger <Reimar.Doeffinger at gmx.de> writes:
> 
> > Hello,
> > just a possible suggestion to avoid some "magic" in the table generators.
> > I freely admit there maybe are already too many "hacks" related to this
> > feature in the Makefile, but currently Michael is complaining louder than
> > M?ns :-)
> >
> > Reimar
> >
> > Index: libavcodec/Makefile
> > ===================================================================
> > --- libavcodec/Makefile	(revision 22622)
> > +++ libavcodec/Makefile	(working copy)
> > @@ -633,7 +633,7 @@
> >  endif
> >  
> >  $(SUBDIR)%_tablegen$(HOSTEXESUF): $(SUBDIR)%_tablegen.c $(SUBDIR)tableprint.c
> > -	$(HOSTCC) $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^ $(HOSTLIBS)
> > +	$(HOSTCC) -Dav_cold= -DCONFIG_HARDCODED_TABLES=0 $(HOSTCFLAGS) $(HOSTLDFLAGS) -o $@ $^ $(HOSTLIBS)
> 
> I don't like this.

What about my suggestion for a hostconfig.h or something like that containing
these and some other hacks currently in the Makefile?
Or some hoststubs.h header file that e.g. include avconfig.h but redefines
HARDCODED_TABLES, removes some defines that might differ between host and
target and has stubs av_cold etc.?
Any other idea?