[FFmpeg-devel] [PATCH] cleanup image2pipe_{de}muxer fields

[Aurelien Jacobs]

On Thu, Oct 21, 2010 at 02:23:32PM -0700, Pascal Massimino wrote:
> Aurelien,
> 
> On Thu, Oct 21, 2010 at 2:00 PM, Aurelien Jacobs <aurel at gnuage.org> wrote:
> 
> > On Tue, Oct 19, 2010 at 07:15:44AM -0700, Pascal Massimino wrote:
> > > Hi,
> > >
> > > $attached
> > > cosmetic, but handy.
> > >
> > > [...]
> > >
> > >  /* output */
> > >  #if CONFIG_IMAGE2_MUXER
> > >  AVOutputFormat image2_muxer = {
> > > -    "image2",
> > > -    NULL_IF_CONFIG_SMALL("image2 sequence"),
> > > -    "",
> > > -
> >  "bmp,jpeg,jpg,ljpg,pam,pbm,pcx,pgm,pgmyuv,png,ppm,sgi,tga,tif,tiff,jp2",
> > > -    sizeof(VideoData),
> > > -    CODEC_ID_NONE,
> > > -    CODEC_ID_MJPEG,
> > > -    img_write_header,
> > > -    img_write_packet,
> > > -    NULL,
> > > -    .flags= AVFMT_NOTIMESTAMPS | AVFMT_NODIMENSIONS | AVFMT_NOFILE
> > > +    .name = "image2",
> > > +    .long_name = NULL_IF_CONFIG_SMALL("image2 sequence"),
> >
> > > +    .mime_type = "",
> >
> > Seems useless.
> >
> > > +    .extensions =
> > "bmp,jpeg,jpg,ljpg,pam,pbm,pcx,pgm,pgmyuv,png,ppm,sgi,tga,tif,tiff,jp2",
> > > +    .priv_data_size = sizeof(VideoData),
> >
> > > +    .audio_codec = CODEC_ID_NONE,
> >
> > useless.
> >
> > > +    .video_codec = CODEC_ID_MJPEG,
> > > +    .write_header = write_header,
> > > +    .write_packet = write_packet,
> > > +    .flags = AVFMT_NOTIMESTAMPS | AVFMT_NODIMENSIONS | AVFMT_NOFILE
> >
> > Also you should use this opportunity to properly align those
> > initialisations (all '=' on the same column).
> >
> > All those comments apply to all the stucts you modified.
> >
> >
> as in $attached?

Yes. Looks good to me.

Aurel