[FFmpeg-devel] Patch for Issue 2317

[Ronald S. Bultje]

Hi,

On Wed, Oct 27, 2010 at 7:47 PM, Carl Eugen Hoyos <cehoyos at ag.or.at> wrote:
> Rocky Cardwell <rocky.cardwell <at> lifespringschool.org> writes:
>> Attached is a potential patch for Issue 2317: Segfault when trying to
>> stream any video to ffserver.
>
> In case the patch is ok in principle, I'll happily split it.
[..]
> @@ -642,8 +663,9 @@ static int read_ffserver_streams(AVForma
>      if (err < 0)
>          return err;
>      /* copy stream format */
> -    s->nb_streams = ic->nb_streams;
> +    s->nb_streams = 0;
>      for(i=0;i<ic->nb_streams;i++) {
> +        s->nb_streams++;
>          AVStream *st;
>          AVCodec *codec;

Mixing statements/declarations.

More importantly, while I think this is the correct fix for the
problem, the separation between "normal" ffmpeg and
"ffserver-connected" ffmpeg is problematic in that we don't test the
latter. Is there some way to add a fate-test for it or so?

Ronald