[FFmpeg-devel] [PATCH] fix h264_deblock_sse2.asm segfaults on clang/x86-32

[Ronald S. Bultje]

Hi Michael,

On Thu, Sep 2, 2010 at 4:44 AM, Michael Niedermayer <michaelni at gmx.at> wrote:
> I dont mind if people disable optimized code for clang or add such
> workarounds conditional on the compiler being clang.

Well, the "problem" is that the compiler isn't clang. The compiler is
yasm, the calling code is clang-compiled. (Same bug likely applies to
old icc and some of the other "exotic" compilers on fate that fail the
h264 tests.)

If we add a config.asm that is a yasmified config.h, and have both
define the C compiler being used to conditionally enable this
"hack"/"fix" in deblock asm, would that be acceptable to you?

> But iam against such workarounds being added as if it was a bugfix
> because once clang will be fixed all these hacks would then be forgoten
> without ifdef clang/buggy_whatever. And there are enough hacks in the
> code that noone knows why they where added

Doesn't svn (git) history show that?

Ronald