[FFmpeg-devel] [PATCH] nasm support

Dave Yeo daveryeo
Sat Sep 4 21:53:50 CEST 2010


On 09/04/10 12:33 am, Reimar D?ffinger wrote:
> On Fri, Sep 03, 2010 at 08:43:10PM -0700, Dave Yeo wrote:
>> Thank you
>>
>> On 09/03/10 10:05 am, Reimar D?ffinger wrote:
>>> On Fri, Sep 03, 2010 at 06:56:03PM +0200, Reimar D?ffinger wrote:
>>>> Hello,
>>>> this allows compiling FFmpeg asm code with nasm.
>>>> Advantages:
>>>> 1) nasm support OS/2 OMF format
>>
>> Easier to use aout and convert at the linking stage. OMF defaults to
>> 16 bit under nasm and we already use aout for the object files.
>
> yasm can't even produce a.out ?

Nope.

>
>>>> 2) there's a Cygwin package for nasm
>>>> Tested on 64 bit Linux, compiles and passes tests.
>>>> Obviously it would be a good idea for someone to test it
>>>> on 32 bit...
>>
>> Needed a couple of
>> -section .text align=16
>> +section .text
>> +align 16
>> to assemble here.
>
> Well, if anything all should be converted.
> However I am not sure these are actually doing the same thing?
> Aligning the section and aligning the data inside it do not
> necessarily have to be the same thing.

I asked the nasm people as I only needed this change for -f aout. The 
answer was,
"aout doesn't support align= section attribute, obj in turn does support 
that is why it doesn't require any changes"
So I guess that change was wrong and it would be better to use OMF.

> Also I had not such problem here with 2.08.02, can you make
> sure you have that or a newer version?

I downloaded the newest nightly, works the same as the 2.08.01 I was using.
Dave



More information about the ffmpeg-devel mailing list