[FFmpeg-devel] [PATCH] Create ff_amr_bit_reorder() in a shared amr.h file

[Marcelo Galvão Póvoa]

On 8 September 2010 09:07, Vitor Sessak <vitor1001 at gmail.com> wrote:
> On 09/07/2010 12:02 AM, Marcelo Galv?o P?voa wrote:
>>
>> Hello,
>>
>> I am not sure if it is the best way to do it, maybe it's better to
>> move the memset outside the function. Unfortunately, I had to convert
>> several tables in amrnbdata.h from uint8_t to uint16_t because
>> amrwbdata.h uses the latter.
>
> If you split the order tables in two (one for the pulses and one for the
> rest) can you replace in AMRWB
>
> ff_amr_bit_reorder(ctx, size, data, order_mode);
>
> by
>
> ff_amr_bit_reorder(ctx, size, data, order_mode);
> ff_amr_bit_reorder(ctx, size2, data + 8, order_mode_pulses);
>
> in a way that you can keep uint8_t for the order tables?
>

I don't know if I understand that correctly but the pulse bits aren't
all contained after the first byte. For example, for this pulse:

11, AMR_OF(1, pul_ih[2]), 106, 134, 125, 154, 205, 267, 306, 220,
                          185, 330, 297,

Some bits would have to be in one table and the rest in another, which
would break the reordering function.

-- 
Marcelo