[FFmpeg-devel] [PATCH 4/10] GXF Encoder Fixes and HD support (patch broken up)

Baptiste Coudurier baptiste.coudurier
Thu Sep 9 22:33:32 CEST 2010


On 09/08/2010 06:37 PM, Reuben Martin wrote:
> Yo, back on Wednesday, September 08, 2010 Reuben Martin was all like:
>> 04-gxf__line_height_mod16_error.patch
>>
>> BUG: The encoded line hight value was set one increment too low for line-heights not an even multiple of 16. (e.g. 1080i content was tagged as having an encoded line-height of 1072 instead of 1088)
>>
>
>
> 04-gxf__line_height_mod16_error.patch
>
>
> --- ffmpeg-old/libavformat/gxfenc.c	2010-09-08 16:49:02.862000170 -0500
> +++ ffmpeg-new/libavformat/gxfenc.c	2010-09-08 16:53:15.488000096 -0500
> @@ -190,7 +190,7 @@
>                       "Pix 0\nCf %d\nCg %d\nSl %d\nnl16 %d\nVi 1\nf1 1\n",
>                       (float)st->codec->bit_rate, sc->p_per_gop, sc->b_per_i_or_p,
>                       st->codec->pix_fmt == PIX_FMT_YUV422P ? 2 : 1, sc->first_gop_closed == 1,
> -                    starting_line, st->codec->height / 16);
> +                    starting_line, st->codec->height % 16 == 0 ? (st->codec->height / 16) : ((st->codec->height / 16) + 1 );
>       put_byte(pb, TRACK_MPG_AUX);
>       put_byte(pb, size + 1);
>       put_buffer(pb, (uint8_t *)buffer, size + 1);

(st->codec->height + 15) / 16

-- 
Baptiste COUDURIER
Key fingerprint                 8D77134D20CC9220201FC5DB0AC9325C5C1ABAAA
FFmpeg maintainer                                  http://www.ffmpeg.org



More information about the ffmpeg-devel mailing list