[FFmpeg-devel] [PATCH] av_log repeating

[Måns Rullgård]

Michael Niedermayer <michaelni at gmx.at> writes:

> On Mon, Sep 13, 2010 at 11:46:15PM +0100, M?ns Rullg?rd wrote:
>> Michael Niedermayer <michaelni at gmx.at> writes:
>> 
>> > On Mon, Sep 13, 2010 at 11:13:36PM +0100, M?ns Rullg?rd wrote:
>> >> Michael Niedermayer <michaelni at gmx.at> writes:
>> >> 
>> >> > Hi
>> >> >
>> >> > patch below disabled the (hated by some) repeating in av_log() and adds an
>> >> > option for apps to turn it on again
>> >> >
>> >> > comments?
>> >> >
>> >> > (yes ill bump vers & add appchanges entry if people agree to this)
>> >> >
>> >> > alternatively we can also completely drop the repeat code ...
>> >> 
>> >> It was fine before your last change.  Now it spews just as many
>> >> messages as without repeat detection.  It makes log files horrible to
>> >> read if there are many repeated messages.
>> >> 
>> >> Printing the increasing counter with \r might be acceptable on a
>> >> terminal (although it makes the next non-repeated message unreadable
>> >> if it is shorter), but not otherwise.
>> >
>> > we need a solution not complaints
>> >
>> > btw, isnt there something on posix that can clean these \r in a terminal
>> > simulating manner out of a file ?
>> 
>> Of course something can be done with awk or sed, but that's not the
>> point.
>
> i didnt really mean it as solution for this otherwise i wouldnt have posted
> that patch, i was more curious if there was a easy way to flatten all the
> codes into a nice ascii/utf8 file. ffmpeg isnt the only thing from where
> one can end up with things that need that ...

tr '\r' '\n' might do what you want in some cases.

>> The proper solution is to not print the repeated messages in the first
>> place.  We already check for a terminal to enable the colouring of log
>> output.  Do the same thing if you insist on printing those lines.
>
> ok and done

No, not done.

-- 
M?ns Rullg?rd
mans at mansr.com