[FFmpeg-devel] [PATCH] float values for libmp3lame quality

[Måns Rullgård]

James Darnley <james.darnley at gmail.com> writes:

> 2010/9/15 M?ns Rullg?rd <mans at mansr.com>:
>> James Darnley <james.darnley at gmail.com> writes:
>>
>>> 2010/9/14 M?ns Rullg?rd <mans at mansr.com>:
>>>> If a single test for a good version which has everything we need is
>>>> possible, do that. ?It seems like replacing lame_init with
>>>> hip_decode_init should do it.
>>>>
>>>
>>> Okay, just the one check but I left the explicit error message
>>>
>>> From 402537b93e5b7f9e09789b0d9e5180cab2b0c23d Mon Sep 17 00:00:00 2001
>>> From: James Darnley <james.darnley at gmail.com>
>>> Date: Tue, 14 Sep 2010 10:57:19 +0200
>>> Subject: [PATCH 3/3] float values for libmp3lame quality
>>>
>>> ---
>>> ?configure ? ? ? ? ? ? ? | ? ?3 ++-
>>> ?libavcodec/libmp3lame.c | ? ?2 +-
>>> ?2 files changed, 3 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/configure b/configure
>>> index 26db167..d887cb1 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -2714,7 +2714,8 @@ enabled libdirac ? && add_cflags $(pkg-config --cflags dirac) &&
>>> ? ? ? ? ? ? ? ? ? ? ? ?require ?libdirac libdirac_encoder/dirac_encoder.h dirac_encoder_init $(pkg-config --libs dirac)
>>> ?enabled libfaac ? ?&& require2 libfaac "stdint.h faac.h" faacEncGetVersion -lfaac
>>> ?enabled libgsm ? ? && require ?libgsm gsm/gsm.h gsm_create -lgsm
>>> -enabled libmp3lame && require ?libmp3lame lame/lame.h lame_init -lmp3lame
>>> +enabled libmp3lame && { check_lib lame/lame.h hip_decode_init -lmp3lame ||
>>> + ? ? ? ? ? ? ? ? ? ? ? ?die "ERROR: libmp3lame version must be >= 3.98.3"; }
>>
>> Please leave this as it is, only changing the checked function.
>>
>
> Why do you not want an explicit error message?

It doesn't belong in this patch, and it can be done in a better way.

-- 
M?ns Rullg?rd
mans at mansr.com