[FFmpeg-devel] [PATCH] rtsp: Handle standard assigned codec names for private payload types, too

[Ronald S. Bultje]

Hi,

On Mon, Sep 13, 2010 at 2:44 AM, Martin Storsj? <martin at martin.st> wrote:
> On Sun, 12 Sep 2010, Ronald S. Bultje wrote:
>> On Sat, Sep 11, 2010 at 3:24 PM, Martin Storsj? <martin at martin.st> wrote:
>> > In most cases, the payload type in RTP is one of the standard assigned
>> > numbers (below 96) for codecs that have a standard number assigned, and
>> > private/dynamic ones for others. If, for some reason, a stream uses a
>> > dynamic payload type number for a codec with a standard type, we currently
>> > fail to open the stream properly. The attached patch uses ff_rtp_codec_id
>> > to find the right codec ID for such streams, if no matching dynamic
>> > handler was found.
>>
>> I think rtpdec.c already handles this, e.g. for PCM audio etc.
>
> No, it doesn't. rtpdec.c never is given the textual string that describes
> the payload from the rtpmap SDP line, it's never passed outside of
> sdp_parse_rtpmap in rtsp.c, so we need to map it into a codec id there.

Hm, ok, can you add that in a comment then? I would expect it to, but
I totally see how that'd be tripple the code of this. So it's ok with
a comment.

Ronald