[FFmpeg-devel] [PATCH] float values for libmp3lame quality

[Måns Rullgård]

James Darnley <james.darnley at gmail.com> writes:

> 2010/9/16 M?ns Rullg?rd <mans at mansr.com>:
>> James Darnley <james.darnley at gmail.com> writes:
>>
>>> 2010/9/15 M?ns Rullg?rd <mans at mansr.com>:
>>>> James Darnley <james.darnley at gmail.com> writes:
>>>>> Why do you not want an explicit error message?
>>>>
>>>> It doesn't belong in this patch, and it can be done in a better way.
>>>
>>> Can you elaborate on that?
>>
>> You could simply include the version in the first parameter to 'require'.
>
> How about this?
>
> diff --git a/configure b/configure
> index dc2f03d..029ed9a 100755
> --- a/configure
> +++ b/configure
> @@ -2715,7 +2715,7 @@ enabled libdirac   && add_cflags $(pkg-config --cflags dirac) &&
>                        require  libdirac libdirac_encoder/dirac_encoder.h dirac_encoder_init $(pkg-config --libs dirac)
>  enabled libfaac    && require2 libfaac "stdint.h faac.h" faacEncGetVersion -lfaac
>  enabled libgsm     && require  libgsm gsm/gsm.h gsm_create -lgsm
> -enabled libmp3lame && require  libmp3lame lame/lame.h hip_decode_init -lmp3lame
> +enabled libmp3lame && require  "libmp3lame >= 3.98.3" lame/lame.h hip_decode_init -lmp3lame
>  enabled libnut     && require  libnut libnut.h nut_demuxer_init -lnut
>  enabled libopencore_amrnb  && require libopencore_amrnb opencore-amrnb/interf_dec.h Decoder_Interface_init -lopencore-amrnb
>  enabled libopencore_amrwb  && require libopencore_amrwb opencore-amrwb/dec_if.h D_IF_init -lopencore-amrwb

OK

-- 
M?ns Rullg?rd
mans at mansr.com