[FFmpeg-devel] [RFC] stream parsing

Benjamin Larsson banan
Sun Sep 26 22:46:35 CEST 2010


On 09/26/2010 02:14 PM, Michael Niedermayer wrote:
> On Sun, Sep 26, 2010 at 12:54:34PM +0200, Benjamin Larsson wrote:
>>
>>>
>>> this looks strange
>>> i would have expected a
>>> if((codec->capabilities & CODEC_CAP_CHANNEL_CONF) && !channel_layout)
>>>     return 0;
>>>
>>> in has_codec_parameters()
>>
>>
>> There is no AVCodec available in has_codec_parameters() only an
>> AVCodecContext.
> 
> AVCodecContext.codec

Yes I know but it is NULL at that time.

>>
>> Anyway I redid the patch, it's abit more logical now but pretty much the
>> same.
>>
>> Btw in has_codec_parameters() there is a list of codecs with some
>> special casing, I think these codecs should have this new capability set.
> 
> simplifications is welcome
> 

Well if this patch is approved I will submit the additional
simplifications. So is the patch acceptable ?

MvH
Benjamin Larsson



More information about the ffmpeg-devel mailing list