[FFmpeg-devel] [PATCH] Add af_resample - sample fmt and channel layout conversion filter

[Michael Niedermayer]

On Mon, Sep 27, 2010 at 02:41:16AM +0200, Stefano Sabatini wrote:
> On date Monday 2010-09-27 02:21:49 +0200, Michael Niedermayer encoded:
> > On Mon, Sep 27, 2010 at 12:40:31AM +0200, Stefano Sabatini wrote:
> [...]
> > > > the functions belong to libavfilter
> > > > what is the plan to move them there?
> > > 
> > > Impossible as lavc uses that functions internally.  The plan was to
> > 
> > resample uses them, resample doesnt belong to lavc, not more than
> > sws would belong there
> > 
> > 
> > > directly use them, and move to something better when we'll have a
> > > revisited resampling/conversion API, a libavresample was mentioned.
> > > Since this is not going to take small time, the idea was to use the
> > > quickest solution and not stall audio lavfi development.
> > 
> > the quickest is to copy the 2 pages of poor code not to export it as
> > public ABI/API from the wrong lib
> > that API/ABI requires maintaince and is not a small burden when things
> > have to be moved to the correct place or when API/ABI changes which with
> > such trashy code will happen unless development stops
> 
> OK so the quickest path looks like to duplicate the code as it was
> done in the original version from Hemanth...

yes, i dont like it but i think this is a rare case where this will cause
fewer problems

also the code in libavcodec should be marked as deprecated as soon as possible

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many that live deserve death. And some that die deserve life. Can you give
it to them? Then do not be too eager to deal out death in judgement. For
even the very wise cannot see all ends. -- Gandalf
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.mplayerhq.hu/pipermail/ffmpeg-devel/attachments/20100927/29b2eeef/attachment.pgp>