[FFmpeg-devel] [PATCH] add fieldorder video filter

Michael Niedermayer michaelni at gmx.at
Sat Apr 2 18:28:39 CEST 2011


On Fri, Apr 01, 2011 at 07:31:41PM +0100, Mark Himsley wrote:
[...]
> +static void draw_slice(AVFilterLink *inlink, int y, int h, int slice_dir)
> +{
> +    AVFilterContext   *ctx        = inlink->dst;
> +    FieldOrderContext *fieldorder = ctx->priv;
> +    AVFilterLink      *outlink    = ctx->outputs[0];
> +
> +    AVFilterBufferRef *inpicref   = inlink->cur_buf;
> +
> +    /** can only do slices if filter is doing nothing,
> +     *  because this filter has to read from pixels outside of the slice */
> +    if (   !inpicref->video->interlaced
> +        || inpicref->video->top_field_first == fieldorder->dst_tff) {
> +        avfilter_draw_slice(outlink, y, h, slice_dir);
> +    }
> +}

I dont see this problem, a slice from 16..32 can just be output to
15..31
its maybe not the easiest thing, requireing some corner cases to be
handeld but it can be done.

Of course this isnt needed to get the patch approved. its fine as is
If you dont want to work on the more generic slice support

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110402/1f3237f5/attachment.asc>


More information about the ffmpeg-devel mailing list