[FFmpeg-devel] [PATCH]Move MLP channel layout setting from parser to decoder

Carl Eugen Hoyos cehoyos at ag.or.at
Wed Apr 13 10:17:35 CEST 2011

John Stebbins <stebbins <at> jetheaddev.com> writes:

> > This allows the mlp channel re-order patch to also work with other
> > applications than ffmpeg/ffplay.

> Is there an order of operations problem here? channel_layout gets set before
> channels in read_major_sync.  If channels hasn't been set yet, doesn't the
> test for av_get_channel_layout_nb_channels(channel_layout) != channels fail
> the first time through?

It does not trigger for me (I only tested one sample), but I will change it to
if (channels && av_get_channel_layout_nb_channels ...

Any other comments?

Thank you, Carl Eugen

More information about the ffmpeg-devel mailing list