[FFmpeg-devel] [PATCH] Per-frame metadata

Nicolas George nicolas.george at normalesup.org
Wed Apr 13 13:07:44 CEST 2011

Le tridi 23 germinal, an CCXIX, Stefano Sabatini a écrit :
> In many cases we propagate the error code, not having to remap it is a
> bonus.

I do not really see the bonus between

	if (av_size_mult(siezof(foo, n, &size) < 0)
	    return AVERROR(EINVAL);


	r = av_size_mult(siezof(foo, n, &size);
	if (r < 0)
	    return r;

The only benefit I see is in term of API uniformity, thus the question:

Do you think this is worth making mem.h depend on error.h?

> My argument is that metadata is not codec-specific, so I consider
> libavutil a better place (and at least per-frame metadata filtering
> looks senseful, even if I can't imagine other uses outside libavcodec
> at the moment).

I perfectly understand the argument, and in fact I agree with it. I will
wait a bit more to see if there are other remarks, especially from Michael.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110413/60cf4458/attachment.asc>

More information about the ffmpeg-devel mailing list