[FFmpeg-devel] [PATCH]Move MLP channel layout setting from parser to decoder

Carl Eugen Hoyos cehoyos at ag.or.at
Thu Apr 14 01:35:52 CEST 2011

John Stebbins <stebbins <at> jetheaddev.com> writes:

> I was thinking the test needed to be moved to after where channels gets set.

iiuc, they can be set on different places in the code, one is the parser, and
layout should be set in the decoder.

> I don't entirely understand under what conditions that test would be
> triggered, but it seems like in cases where it would be triggered,

For samples that contain both a LFE and LFE2 or both a "Ts" and a "Cvh" channel
(whatever they may be).

> the current position of that test would cause it to trigger on the *next*
> call to read_access_unit after the number of channels change.  So for 
> one packet, the value would be incorrect.

Thank you for explaining!
I believe we should really ask for such samples so imo, this (unintended) change
is very welcome;-)

I will commit my change, it can still be reverted if a better solution is found.

Thank you, Carl Eugen

More information about the ffmpeg-devel mailing list