[FFmpeg-devel] "reviews"

Michael Niedermayer michaelni at gmx.at
Thu Apr 14 03:40:04 CEST 2011

Hi Luca "Fine for me"
Hi Ronald "Pushed"

Could at least one of you, please open at least one of your eyes
when doing your fake reviews!

The Change below makes libav generate invalid non spec compliant
You even updated the regression test checksums, are you blind ???

Ive of course fixed it in ffmpeg during the merge like i do every
day but honestly, this is starting to become unfunny.
What do you actually review, this patch changed just 4 lines + the
checksum updates.

--- a/libavformat/utils.c
+++ b/libavformat/utils.c
@@ -3063,7 +3063,10 @@ static int ff_interleave_compare_dts(AVFormatContext *s, AVPacket *next, AVPacke
     AVStream *st2= s->streams[ next->stream_index];
     int64_t a= st2->time_base.num * (int64_t)st ->time_base.den;
     int64_t b= st ->time_base.num * (int64_t)st2->time_base.den;
-    return av_rescale_rnd(pkt->dts, b, a, AV_ROUND_DOWN) < next->dts;
+    int64_t dts1 = av_rescale_rnd(pkt->dts, b, a, AV_ROUND_DOWN);
+    if (dts1 == next->dts)
+        return pkt->stream_index < next->stream_index;
+    return dts1 < next->dts;

Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110414/e6f82a25/attachment.asc>

More information about the ffmpeg-devel mailing list