[FFmpeg-devel] [PATCH] CrystalHD: Fix usage of h264 parser.

Philip Langdale philipl at overt.org
Fri Apr 15 06:21:20 CEST 2011


On Fri, 15 Apr 2011 05:09:23 +0200
Michael Niedermayer <michaelni at gmx.at> wrote:

> 
> Theres a code example above the
> 
> av_parser_parse2() function in libavcodec/avcodec.h
> your code does not seem correct if iam not too tired

My code is likely wrong, but the 'pos' parameter is confusing
me. It is described as the "input byte position in stream" but
the example doesn't advance it inside the while loop, which
seems illogical. The implementation of parse2() seems to just
pass it around on behalf of the caller without using it, except
when initializing cur_offset. At this point, I don't know what
I should pass for the pos value, but perhaps it doesn't matter.

I haven't found a real world example of the api being used.

--phil
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110414/14347acc/attachment.asc>


More information about the ffmpeg-devel mailing list