[FFmpeg-devel] [PATCH] Fix colors for DVD subtitles

Reimar Döffinger Reimar.Doeffinger at gmx.de
Sat Apr 23 17:41:33 CEST 2011

On Thu, Apr 21, 2011 at 11:25:33AM +0200, Alexandre Colucci wrote:
> Hi,
> This patch fixes the DVD subtitle colors/alpha info. See screenshots for before and after the patch.

I don't think that is correct.
First, the yellow colour was chosen on purpose, and a lot of DVDs
use yellow but in principle one is as good as the other.
Secondly the function is called guess_palette for a reason:
It is a guess. It will be wrong. But so will yours.
Unless you have very good data to believe that yours actually
works better significantly more often I don't think there's a
good reason to change the code.

More information about the ffmpeg-devel mailing list