[FFmpeg-devel] [RFC][PATCH] Move picture type definitions from libavcodec to libavutil

[Michael Niedermayer]

On Sat, Apr 23, 2011 at 08:47:01PM +0200, Stefano Sabatini wrote:
> From: Stefano Sabatini <stefano.sabatini-lala at poste.it>
> To: FFmpeg development discussions and patches <ffmpeg-devel at ffmpeg.org>
> Cc: 
> Bcc: 
> Subject: Re: [FFmpeg-devel] [RFC][PATCH] Move picture type definitions from
> 	libavcodec to libavutil
> Reply-To: 
> In-Reply-To: <20110423175414.GB19660 at kiste2>
> 
> On date Saturday 2011-04-23 19:54:14 +0200, Michael Niedermayer encoded:
> > On Sat, Apr 23, 2011 at 05:28:30PM +0200, Stefano Sabatini wrote:
> [...]
> > > @@ -3863,7 +3863,9 @@ void avcodec_default_free_buffers(AVCodecContext *s);
> > >   *
> > >   * @param[in] pict_type the picture type
> > >   * @return A single character representing the picture type.
> > > + * @deprecated use av_get_picture_type_char() instead
> > >   */
> > > +attribute_deprecated
> > >  char av_get_pict_type_char(int pict_type);
> > 
> > this function looks fine to me, i see no need to change it
> 
> But, it is defined in libavcodec, and I would like to avoid
> breakages as the function is moved from libavcodec to libavutil.
> 
> The new function in libavutil has a different name
> (av_get_pictURE_type_char), which is also sligthly more consistent
> with the enum name.

IMHO
every rename causes work for the developers of user applications. who
must adapat their code. moving the fuinction without changing its name
means less work for them.


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

I have never wished to cater to the crowd; for what I know they do not
approve, and what they approve I do not know. -- Epicurus
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110424/5e9c984c/attachment.asc>