[FFmpeg-devel] [PATCH] Base parser frame_offset on correct packet pos.

Michael Niedermayer michaelni at gmx.at
Sun Apr 24 14:16:14 CEST 2011

On Sun, Apr 10, 2011 at 01:25:20AM +0200, Reimar Döffinger wrote:
> The current code only works if the next buffer starts directly
> after the previous one in the file. For formats with some sort
> of framing that is not necessarily the case.
> Without this change, GENERIC_INDEX with needs_parsing and framing
> that causes the stream to be non-consecutive results in a broken
> index being generated.

> This is probably also a bug in the generic index code, it probably
> should ignore the parser output and instead always seek to some
> pkt->pos, or at the very least only use it when full parsing is requested.

yes with framing and non consecutive packets the only thing that makes
sense generically is using pkt->pos

the various offsets are IIRC all supposed to be ofsets within a stream
not within a file
I do not know what effect it would have to redefine them to be offsets
within a file.


Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Breaking DRM is a little like attempting to break through a door even
though the window is wide open and the only thing in the house is a bunch
of things you dont want and which you would get tomorrow for free anyway
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20110424/864f5abc/attachment.asc>

More information about the ffmpeg-devel mailing list