[FFmpeg-devel] [PATCH 3/5] lavf: add av_ prefix to find_info_tag

[Stefano Sabatini]

On date Sunday 2011-02-06 20:16:20 +0100, Anton Khirnov encoded:
> On Sun, Feb 06, 2011 at 03:49:25PM +0100, Michael Niedermayer wrote:
> > On Sun, Feb 06, 2011 at 03:46:48PM +0100, Anton Khirnov wrote:
> > [...]
> > > --- a/libavformat/avformat.h
> > > +++ b/libavformat/avformat.h
> > > @@ -1518,13 +1518,17 @@ int64_t ffm_read_write_index(int fd);
> > >  int ffm_write_write_index(int fd, int64_t pos);
> > >  void ffm_set_write_index(AVFormatContext *s, int64_t pos, int64_t file_size);
> > >  
> > > +#if FF_API_FIND_INFO_TAG
> > > +attribute_deprecated int find_info_tag(char *arg, int arg_size, const char *tag1, const char *info);
> > > +#endif
> > > +
> > >  /**
> > >   * Attempt to find a specific tag in a URL.
> > >   *
> > >   * syntax: '?tag1=val1&tag2=val2...'. Little URL decoding is done.
> > >   * Return 1 if found.
> > >   */
> > > -int find_info_tag(char *arg, int arg_size, const char *tag1, const char *info);
> > > +int av_find_info_tag(char *arg, int arg_size, const char *tag1, const char *info);
> > >  
> > >  /**
> > >   * Return in 'buf' the path with '%d' replaced by a number.
> > 
> > This doesnt belong on libavformat IMHO
> moved to libavcore
> 
> -- 
> Anton Khirnov

> From d79f7c54b619f1cf5c70816da55ff04fe6376ede Mon Sep 17 00:00:00 2001
> From: Anton Khirnov <anton at khirnov.net>
> Date: Sun, 6 Feb 2011 15:21:11 +0100
> Subject: [PATCH] Move find_info_tag to lavco and add av_ prefix to it
> 
> ---
>  ffserver.c             |    7 ++++---
>  libavcore/avcore.h     |    8 ++++++++
>  libavcore/utils.c      |   39 +++++++++++++++++++++++++++++++++++++++
>  libavformat/avformat.h |   10 +++-------
>  libavformat/rtpproto.c |   15 ++++++++-------
>  libavformat/sapenc.c   |    9 +++++----
>  libavformat/sdp.c      |    3 ++-
>  libavformat/udp.c      |   15 ++++++++-------
>  libavformat/utils.c    |   41 ++++++-----------------------------------
>  libavformat/version.h  |    3 +++
>  10 files changed, 86 insertions(+), 64 deletions(-)

I don't know which is the best place but maybe avcore.h is not the
right place, parseutils.h would better (or even libavcore/url.h if we
have more functions related to URL parsing/processing).
-- 
FFmpeg = Frightening Foolish Martial Plastic EnGine